Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against PHP 7.4 #672

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Test against PHP 7.4 #672

merged 2 commits into from
Jan 11, 2020

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Jan 7, 2020

No description provided.

.travis.yml Show resolved Hide resolved
For what I understand reading the history, nightly was something used to
represent the next PHP version. This was a good intention, but at the
end Travis builds as nightly has very little in common with whatever
lands as a final release. So building against nightly is only a waste of
electricity, and no one reads its log because it gives zero value:
nightly errors may disappears once new PHP version is published.
@Slamdunk Slamdunk requested a review from greg0ire January 8, 2020 06:36
@greg0ire greg0ire merged commit 753c87e into doctrine:master Jan 11, 2020
@greg0ire
Copy link
Member

Thanks @Slamdunk !

@Slamdunk Slamdunk deleted the php_74 branch January 11, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants